Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend)[NMP-706]: Calculation Fixes to Fertigation Modal #715

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix(frontend)[NMP-706]: Calculation Fixes to Fertigation Modal #715

merged 2 commits into from
Dec 20, 2024

Conversation

lunamoonmoon
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

Amendments to calculations for fertigation modal as noted here fertigation math

This PR includes the following proposed change(s):

  • Change to soluble calculation amountToDissolve <= tankVolume * solInWater/1000
  • Change to nutrient concentration calculation (tankVolume * 1.20095m)

Time is correct when at more decimal places but other ticket we had the ui fixes to round time to nearest minute
Screenshot 2024-12-19 at 1 25 43 PM

Screenshot 2024-12-19 at 1 07 26 PM

@lunamoonmoon lunamoonmoon linked an issue Dec 19, 2024 that may be closed by this pull request
Fix Solid Fertigation Calculation #706
Closed
3 tasks
@lunamoonmoon lunamoonmoon marked this pull request as ready for review December 19, 2024 21:38
@PaulGarewal PaulGarewal self-requested a review December 19, 2024 22:23
PaulGarewal
PaulGarewal approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@PaulGarewal PaulGarewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, may need to talk to SO's in future if time < 1 min, should we put seconds? May not be necessary

@lunamoonmoon lunamoonmoon merged commit 31d91e6 into master Dec 20, 2024
4 checks passed
@lunamoonmoon lunamoonmoon deleted the 706-calculate branch December 20, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulGarewal PaulGarewal PaulGarewal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Solid Fertigation Calculation
2 participants
@lunamoonmoon @PaulGarewal