Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend)[NMP-705]: UI Fixes to Fertigation Modal #712

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Conversation

lunamoonmoon
Copy link
Contributor

@lunamoonmoon lunamoonmoon commented Dec 10, 2024

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Add information Icon after 'Injection Rate' heading. When clicked, it should read: " Enter the rate in which your fertigation equipment applies fertilizer, not its overall output rate."
  • Add information icon after 'Application Rate' (formerly Production Rate). When clicked, it should read: "The rate of fertilizer to be applied, not the overall output rate of your application system."
  • Add information icon after 'Time Per Application' (formerly Fertigation Time). When clicked, it should read: "The amount of time required to apply fertilizer at the input fertilizer application rate, based on the injection rate entered above."
  • Add information icon after 'Tank Volume' if Dry Fertilizer or Dry Fertilizer (Custom) is selected. When clicked, it should read: "".

Screenshot 2024-12-10 at 4 17 07 PM
Screenshot 2024-12-10 at 4 16 52 PM

@lunamoonmoon
Copy link
Contributor Author

Bug ticket 714 has been created to dive deeper into the tooltips not working on modal change.

@lunamoonmoon lunamoonmoon marked this pull request as ready for review December 11, 2024 23:49
@lunamoonmoon lunamoonmoon linked an issue Dec 17, 2024 that may be closed by this pull request
4 tasks
@PaulGarewal PaulGarewal self-requested a review December 18, 2024 15:12
Copy link
Contributor

@PaulGarewal PaulGarewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lunamoonmoon lunamoonmoon merged commit 9200d97 into master Dec 18, 2024
4 checks passed
@lunamoonmoon lunamoonmoon deleted the 705-icons branch December 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding information icons to certain headers and changing the tool tip text
2 participants