Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT][NMP-670] Calculations for Solid Fertigation #696

Merged
merged 11 commits into from
Oct 2, 2024
Merged

[FEAT][NMP-670] Calculations for Solid Fertigation #696

merged 11 commits into from
Oct 2, 2024

Conversation

PaulGarewal
Copy link
Contributor

@PaulGarewal PaulGarewal commented Oct 2, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Added calculations for solid fertigation (custom and regular)
  • TODO: Clean up of rounding calculated numbers
  • TODO: Conversion of amountToDissolve and TankVolume
  • TODO: Investigate edit of dry fertigation (regular)

@PaulGarewal PaulGarewal self-assigned this Oct 2, 2024
@PaulGarewal PaulGarewal requested a review from a team October 2, 2024 18:18
@PaulGarewal PaulGarewal merged commit 89626bb into master Oct 2, 2024
4 checks passed
@PaulGarewal PaulGarewal deleted the 670-calc-solid-fertigation branch October 2, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallascrichmond dallascrichmond dallascrichmond approved these changes

Assignees

@PaulGarewal PaulGarewal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaulGarewal @dallascrichmond