Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE][NMP-682] Custom Liquid Fertigation #693

Merged
merged 3 commits into from
Sep 20, 2024
Merged

[FEATURE][NMP-682] Custom Liquid Fertigation #693

merged 3 commits into from
Sep 20, 2024

Conversation

PaulGarewal
Copy link
Contributor

@PaulGarewal PaulGarewal commented Sep 20, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Added custom liquid fertigation functionality to fertigation model
  • included validation for the nutrient fields

acatchpole and others added 2 commits September 16, 2024 11:57
@acatchpole
added nutrient fields for liquid custom
6176f4b
@PaulGarewal
feat: Added custom liquidation calculations and validations
d31e3d4 
- added nutrient fields for custom liquidation entries
- confirmed correct calculations
- added calculations to the home nutrients screen
@PaulGarewal PaulGarewal requested a review from a team September 20, 2024 20:13
@PaulGarewal PaulGarewal self-assigned this Sep 20, 2024
@PaulGarewal PaulGarewal merged commit c3a47e6 into master Sep 20, 2024
4 checks passed
@PaulGarewal PaulGarewal deleted the 682-custom-liquid-fertigation branch September 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallascrichmond dallascrichmond dallascrichmond approved these changes

Assignees

@PaulGarewal PaulGarewal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulGarewal @dallascrichmond @acatchpole