Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][NMP-687] Finalize Liquid Fertigation - btn text, datepicker, cleanup #692

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[TASK][NMP-687] Finalize Liquid Fertigation - btn text, datepicker, cleanup #692

merged 1 commit into from
Sep 16, 2024

Conversation

acatchpole
Copy link
Contributor

@acatchpole acatchpole commented Sep 16, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [NMP-###]
  • Documentation is updated to reflect change [README, functions, team documents]

Description

This PR includes the following proposed change(s):

  • Fixed the submit button text not being accurate
  • made that button disabled when model not valid
  • made datepicker NOT have a minimum date
  • some general cleanup of commented code

@acatchpole acatchpole merged commit ddc9090 into master Sep 16, 2024
4 checks passed
@acatchpole acatchpole deleted the 687-submit-btn-and-cleanup branch September 16, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dallascrichmond dallascrichmond dallascrichmond approved these changes

@PaulGarewal PaulGarewal Awaiting requested review from PaulGarewal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acatchpole @dallascrichmond