Merge pull request #353 from bcc-code/feat/aac-cbr

Change AAC encoder to provide CBR

cmd/worker/main.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"os"
+	"os/exec"
 	"reflect"
 	"runtime"
 	"strconv"
@@ -80,6 +81,23 @@ func main() {
 		panic(err)
 	}
 
+	if environment.GetQueue() == environment.QueueAudio {
+		// Test if the libfdk_aac encoder is available
+		cmd := exec.Command("ffmpeg", "-xerror",
+			"-f", "lavfi", "-xerror",
+			"-i", "sine=frequency=1000:duration=0.1",
+			"-c:a", "libfdk_aac",
+			"-f", "null", "-")
+
+		err := cmd.Run()
+		if err != nil {
+			panic(err)
+		}
+
+		if cmd.ProcessState.ExitCode() != 0 {
+			panic("audio worker must support ffmpeg with libfdk_aac")
+		}
+	}
 	workerOptions := worker.Options{
 		DeadlockDetectionTimeout:           time.Hour * 3,
 		DisableRegistrationAliasing:        true, // Recommended according to readme, default false for backwards compatibility

services/transcode/audio.go

@@ -108,7 +108,7 @@ func AudioAac(input common.AudioInput, cb ffmpeg.ProgressCallback) (*common.Audi
 		"-progress", "pipe:1",
 		"-hide_banner",
 		"-i", input.Path.Local(),
-		"-c:a", "aac",
+		"-c:a", "libfdk_aac",
 		"-b:a", input.Bitrate,
 	}
 
@@ -293,7 +293,6 @@ func AudioMP3(input common.AudioInput, cb ffmpeg.ProgressCallback) (*common.Audi
 		params = append(params, "-q:a", fmt.Sprint(getQfactorFromBitrate(input.Bitrate)))
 	}
 
-
 	outputFilePath := filepath.Join(input.DestinationPath.Local(), input.Path.Base())
 	outputFilePath = fmt.Sprintf("%s-%s.mp3", outputFilePath[:len(outputFilePath)-len(filepath.Ext(outputFilePath))], input.Bitrate)