Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixes for docker #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

medcelerate
Copy link

Fixed the dockerfile and added the requirements txt file. All requirements added to requirements.txt

@dromer
Copy link

dromer commented Apr 8, 2020

Can I ask why you are using conda? (I find conda 1) bloated and 2) does OS-level things that it really shouldn't).
Why not virtualenv, pyenv or pipenv?

@medcelerate
Copy link
Author

medcelerate commented Apr 8, 2020 via email

@dromer
Copy link

dromer commented Apr 8, 2020

Conda does way too much "automagic" to my liking (and tends to do many things "the wrong way" too).
Imo it's better to do things more explicitly (and deterministically) then to have conda do things for you.

In this case it's only about installing dependencies from pip no? A virtualenv should suffice I'd say.

@medcelerate
Copy link
Author

I was using virtualenv and pipenv and neither would build properly.

@dromer
Copy link

dromer commented May 20, 2020

Then you are doing it wrong? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants