Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStack & oVirt Support #132

Closed
wants to merge 12 commits into from

Conversation

dupondje
Copy link

We use the netbox-sync tool here, but also wanted to import data from Openstack into Netbox.
As this was not available yet, we did build it :)

This pull req adds support for openstack source and syncs clusters (availability groups) / hypervisors and vm's.

@bb-Ricardo
Copy link
Owner

Hi,

This is amazing, thank you.

First of all: I don't have experience in OpenStack and also no OpenStack environment to test.

In order to add and maintain this I need your help. Would you commit to support and maintain the source?

Would you do that?

@bb-Ricardo bb-Ricardo added this to the 1.3.0 milestone Jan 10, 2022
@dupondje
Copy link
Author

Hi,

As long as we have an OpenStack environment I can help with it :)
If things break on some other openstack version or so, then its a bit harder to debug ...

But as we needed openstack sync, and we used your project as a base, it was the right thing to contribute the source plugin!

@bb-Ricardo
Copy link
Owner

Great, this sounds promising.

Do you think this is useful to test your import against?: https://github.com/rackerlabs/mimic

What we still need:

  • is a updated settings-example.ini
  • a description in docs/
  • a code clean up 😄

I See you copied the VMWare handler. But it seems there quite some config vars which are not used. I know it is quite a bit of work but it would help users and future developers to understand what's possible and how it works.

Then I would happily merge your PR and slowly prepare the next release 🤩

Thank you.

@bb-Ricardo bb-Ricardo changed the base branch from main to development January 13, 2022 14:06
@bb-Ricardo
Copy link
Owner

Hi @dupondje, I would really like to see this source in the next release. Did you have some time to polish this PR a bit?

@dupondje
Copy link
Author

dupondje commented Feb 3, 2022

@bb-Ricardo : its on my TODO list :) i'll push it when done

@bb-Ricardo
Copy link
Owner

@bb-Ricardo : its on my TODO list :) i'll push it when done

Awsome

@dupondje dupondje force-pushed the add_openstack branch 3 times, most recently from e12cd4e to dcaff08 Compare May 5, 2022 09:31
@bb-Ricardo
Copy link
Owner

Hi @dupondje, was wondering if this is ready to merge or if you're still working on this.

@bb-Ricardo bb-Ricardo modified the milestones: 1.3.0, 1.4.0 Aug 24, 2022
@bb-Ricardo
Copy link
Owner

Hey @dupondje, can you please let me know about the current status of this PR?

@ludvik78
Copy link

@dupondje do you have working code for nebox 3.3.0?

@bb-Ricardo bb-Ricardo removed this from the 1.4.0 milestone Jan 12, 2023
@dupondje
Copy link
Author

As netbox-sync received a lot of changed, I modified the sync code for OpenStack also to the latest netbox-sync version.
Testing everything out atm, but seems to work fine :)

@dupondje dupondje changed the title Add openstack Add OpenStack & oVirt Support Aug 25, 2023
Copy link

@ebi-droid ebi-droid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ekrichbaum
Copy link

Is this functional at this stage? Can we get it pushed to main?

@ekrichbaum
Copy link

I rebranched and imported it. Had to fix a few typos and the dependencies but doesn't quite work for me with Ovirt. Let me get these hammered down and I'll resubmit a pull.

@bb-Ricardo
Copy link
Owner

Hi,

The issue with this PR is a maintainer which takes care of this type of source. I don't have an environment to test the integration and therefore would need someone who would take on this role.

@ekrichbaum
Copy link

Gladly. I rebased from your master, integrated his code, fixed some typos and imports and an additional error trap (Ovirt returning a NoneType for provisioned_size).

Ovirt is now working and a few more runs to be sure I got it, then I'll start the OpenStacks roll. Once I have it all together, I'll start a new PR. (btw, I had to unpin pyyaml and pyvmomi versions).

@bb-Ricardo
Copy link
Owner

This sounds amazing.

If I remember correctly the pinning was done due to a bug during installation of pyvivomi. Will have a look later into it to see if it has been fixed by now and we are able to move to a never version.

@bb-Ricardo
Copy link
Owner

Gladly. I rebased from your master, integrated his code, fixed some typos and imports and an additional error trap (Ovirt returning a NoneType for provisioned_size).

Ovirt is now working and a few more runs to be sure I got it, then I'll start the OpenStacks roll. Once I have it all together, I'll start a new PR. (btw, I had to unpin pyyaml and pyvmomi versions).

Bumped versions in development branch. Would this work for you?

@ekrichbaum
Copy link

Sure. I see you updated the requirements across the board. I had just unpinned. oVirt is working well. Openstacks is proving more difficult although I do have some of the data happening. A server object in Openstack doesn't actually have things like ram and vcpu in the object, so that piece is still pending. I do have it collecting data in a fashion though. that piece just needs work. I can push the PR in general as new or make adjustments in that branch directly. Your call.

@ekrichbaum
Copy link

Fixed working oVirt and 50% openstacks PR: #389

This one should be closed in favor of the more up to date.

@bb-Ricardo bb-Ricardo closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants