-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenStack & oVirt Support #132
Conversation
Hi, This is amazing, thank you. First of all: I don't have experience in OpenStack and also no OpenStack environment to test. In order to add and maintain this I need your help. Would you commit to support and maintain the source? Would you do that? |
Hi, As long as we have an OpenStack environment I can help with it :) But as we needed openstack sync, and we used your project as a base, it was the right thing to contribute the source plugin! |
Great, this sounds promising. Do you think this is useful to test your import against?: https://github.com/rackerlabs/mimic What we still need:
I See you copied the VMWare handler. But it seems there quite some config vars which are not used. I know it is quite a bit of work but it would help users and future developers to understand what's possible and how it works. Then I would happily merge your PR and slowly prepare the next release 🤩 Thank you. |
Hi @dupondje, I would really like to see this source in the next release. Did you have some time to polish this PR a bit? |
@bb-Ricardo : its on my TODO list :) i'll push it when done |
Awsome |
e12cd4e
to
dcaff08
Compare
Hi @dupondje, was wondering if this is ready to merge or if you're still working on this. |
Hey @dupondje, can you please let me know about the current status of this PR? |
@dupondje do you have working code for nebox 3.3.0? |
cbf930b
to
dd49764
Compare
As netbox-sync received a lot of changed, I modified the sync code for OpenStack also to the latest netbox-sync version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Is this functional at this stage? Can we get it pushed to main? |
I rebranched and imported it. Had to fix a few typos and the dependencies but doesn't quite work for me with Ovirt. Let me get these hammered down and I'll resubmit a pull. |
Hi, The issue with this PR is a maintainer which takes care of this type of source. I don't have an environment to test the integration and therefore would need someone who would take on this role. |
Gladly. I rebased from your master, integrated his code, fixed some typos and imports and an additional error trap (Ovirt returning a NoneType for provisioned_size). Ovirt is now working and a few more runs to be sure I got it, then I'll start the OpenStacks roll. Once I have it all together, I'll start a new PR. (btw, I had to unpin pyyaml and pyvmomi versions). |
This sounds amazing. If I remember correctly the pinning was done due to a bug during installation of pyvivomi. Will have a look later into it to see if it has been fixed by now and we are able to move to a never version. |
Bumped versions in development branch. Would this work for you? |
Sure. I see you updated the requirements across the board. I had just unpinned. oVirt is working well. Openstacks is proving more difficult although I do have some of the data happening. A server object in Openstack doesn't actually have things like ram and vcpu in the object, so that piece is still pending. I do have it collecting data in a fashion though. that piece just needs work. I can push the PR in general as new or make adjustments in that branch directly. Your call. |
Fixed working oVirt and 50% openstacks PR: #389 This one should be closed in favor of the more up to date. |
We use the netbox-sync tool here, but also wanted to import data from Openstack into Netbox.
As this was not available yet, we did build it :)
This pull req adds support for openstack source and syncs clusters (availability groups) / hypervisors and vm's.