Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect flag in build performance blogpost #334

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix incorrect flag in build performance blogpost #334

merged 1 commit into from
Apr 29, 2024

Conversation

jin
Copy link
Member

@jin jin commented Nov 23, 2023

--experimental_collect_worker_data_in_profiler for collecting worker memory usage, not --experimental_collect_system_network_usage.

@jin jin requested a review from radvani13 as a code owner November 23, 2023 04:04
@jin jin requested review from zhengwei143 and meisterT and removed request for radvani13 November 23, 2023 04:04
Copy link
Contributor

@zhengwei143 zhengwei143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jin jin enabled auto-merge (squash) November 23, 2023 09:33
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that this was not merged yet...

@jin jin merged commit a4caf3b into master Apr 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants