Reject errors instaed of throwing them.

bayleeadamoss · Jan 9, 2017 · 9589e98 · 9589e98
1 parent 5c39e9c
commit 9589e98
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/lib/npmInstall.js b/app/lib/npmInstall.js
@@ -28,9 +28,9 @@ const npmInstall = (name, packagePath) => {
     })
     return new Promise((resolve, reject) => {
       npm.load({}, (npmErr) => {
-        if (npmErr) throw npmErr
+        if (npmErr) return reject(npmErr)
         npm.commands.install(packagePath, packages, (err) => {
-          if (err) throw err
+          if (err) return reject(err)
           installStatus.set(name, 'installed').then(resolve)
         })
       })

diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,9 @@
+## Next
+
+### Bugs
+
+* Better handle npm install exceptions.
+
 ## 0.3.0
 
 ### Features