Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: create a docker image for arm64 as well #118

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CI: create a docker image for arm64 as well #118

wants to merge 2 commits into from

Conversation

shtouff
Copy link

@shtouff shtouff commented Mar 18, 2023

No description provided.

@batfish-bot
Copy link

This change is Reviewable

@shtouff
Copy link
Author

shtouff commented Mar 18, 2023

according to https://docs.docker.com/engine/reference/commandline/buildx_build/#output, the docker output type for buildx is incompatible with multi-platform images. Therefore, I choose to duplicate build and upload tasks for both images.

@shtouff shtouff changed the title create a docker image for arm64 as well CI: create a docker image for arm64 as well Mar 18, 2023
@dhalperi dhalperi requested a review from sfraint March 20, 2023 15:52
@dhalperi
Copy link
Member

I've asked @sfraint to look at this; he set it up. But I wonder if https://docs.docker.com/build/ci/github-actions/multi-platform/ doesn't imply that we should be able to do two images in one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfraint sfraint Awaiting requested review from sfraint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shtouff @batfish-bot @dhalperi