did: improve html-validity

basxsoftwareassociation · Nov 20, 2021 · 2b5fbb5 · 2b5fbb5
1 parent 4ec3fdc
commit 2b5fbb5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/bread/layout/components/modal.py b/bread/layout/components/modal.py
@@ -98,7 +98,10 @@ def with_ajax_content(
 
         modal = cls(
             heading,
-            hg.CENTER(Loading(), style="opacity: 0.5; background-color: #EEE"),
+            hg.DIV(
+                Loading(),
+                style="opacity: 0.5; background-color: #EEE; text-align: center;",
+            ),
             label="",
             buttons=buttons,
             size="md",

diff --git a/bread/layout/components/shell_header.py b/bread/layout/components/shell_header.py
@@ -59,7 +59,6 @@ def __init__(self, platform, company, searchbar, actions=(), *args, **kwargs):
                 _class="bx--header__global",
             ),
             _class="bx--header",
-            role="banner",
             data_header=True,
         )
 
@@ -70,7 +69,7 @@ def logo():
     return hg.IMG(
         src=staticfiles_storage.url("logo.png"),
         _class="bx--header__name--prefix",
-        style="width: 1.7rem; height; 1.7rem; margin-right: 0.5rem",
+        style="width: 1.7rem; height: 1.7rem; margin-right: 0.5rem",
     )
 
 

diff --git a/bread/layout/components/sidenav.py b/bread/layout/components/sidenav.py
@@ -94,7 +94,6 @@ def __init__(self, menu: "bread.menu.Menu", **kwargs):
                                                         " bx--side-nav__menu-item--current",
                                                     ),
                                                 ),
-                                                role="none",
                                             ),
                                         ),
                                         _class="bx--side-nav__menu",
@@ -154,13 +153,11 @@ def __init__(self, menu: "bread.menu.Menu", **kwargs):
                             _class="bx--assistive-text",
                         ),
                         _class="bx--side-nav__toggle",
-                        role="button",
                         onclick="setBreadCookie('sidenav-hidden', getBreadCookie('sidenav-hidden', 'false') != 'true');",
                     ),
                     _class="bx--side-nav__footer",
                 ),
                 _class="bx--side-nav__navigation",
-                role="navigation",
             ),
             **kwargs,
         )
diff --git a/bread/layout/skeleton.py b/bread/layout/skeleton.py
@@ -15,8 +15,6 @@
 def default_page_layout(menu, *content):
     return hg.HTML(
         hg.HEAD(
-            hg.META(charset="utf-8"),
-            hg.META(name="viewport", content="width=device-width, initial-scale=1"),
             hg.TITLE(
                 hg.F(
                     lambda c: strip_tags(c.get("pagetitle", c.get("PLATFORMNAME")))