Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to turn off scheduled entries having a timestamp. #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tostr7191
Copy link

As per #389, I am adding a PR that adds this feature. First time working with this, and I am also on the move, so not quite sure everything is correct. But it looks simple enough, hoping that it actually is.

Otherwise, please feel free to critique in any way, I should have a bit more time next week (but my schedule said I need to do this today, so I complied! ;))

@tostr7191
Copy link
Author

Ok, now I had a bit of time to figure out how to test. All three obvious cases work with expected behaviour (not set, set to t and set to nil).

@bastibe
Copy link
Owner

bastibe commented May 18, 2022

Thank you very much, and sorry for forgetting this pull request for so long!

Would you like to add a note to the README for the new customization variable? Or should this remain in the customization menu only? I'm fine with either approach.

I'll merge the PR when you say it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants