Convert company/member model to new generic layout #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll a few trailing things related to the CompanyType junk. also adding Currency* access permissions and assigning them to the bank role
- adding member `class` enum (MemberClass) and adding Company, User,
Worker options to it, with occupation/compensation living under worker
(company/user are blank structs).
- adding Deletable trait which houses is_deleted() and implementing it
in basis_model!{} as part of the train instead of a direct struct impl.
- adding ActiveState trait, which provides is_active() (depends on
Deletable) and also implementing this in basis_model!{}.
- updating Agent trait to dependon Deletable (so all agents get
is_deletd())
- updating all places/tests where needed to allow this.
there's probably more but going to sign off for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, company members could just be workers.
Now, companies can have three membership classes (oops!!):
Company,User,Worker. In effect we've gone from a flat system that was going to be organized by a one-level-up regional container to a completely fluid system of exitable hierarchies of groups. In effect, the old regional system could be easily modeled by the new system, should participants choose to do so, but other setups are possible as well.All tests passing, although admittedly the
CompanyandUsertypes have only been added to tests in places whereError::MemberMustBeWorkeris implemented.There were some other things in basisproject/tracker#99 like enforcing no circular links in companies or caching all members, but ultimately both of these are really only possible (or at least much more feasible) in the storage layer.