fix(font): update fallback font

basics · Sep 13, 2023 · b49fa7c · b49fa7c
1 parent 315e2fe
commit b49fa7c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 11 deletions.
diff --git a/src/runtime/classes/Font.mjs b/src/runtime/classes/Font.mjs
@@ -50,10 +50,12 @@ export default class Font {
 
   getCSSText({ usedFontaine = false } = {}) {
     const selector = createSelector(this.rootSelector, this.selector);
-    const family = prepareFamily(this.family, { usedFontaine });
+    const family = `"${this.family}"`;
     return wrapByMedia(
       `${selector} {
-        font-family: ${this.fallbackFamily.join(', ')};
+        font-family: ${[getFontaineFallback(this.family, usedFontaine)]
+          .filter(Boolean)
+          .concat(this.fallbackFamily.join(', '))};
         font-weight: ${this.weight};
         font-style: ${this.style};
       }
@@ -64,9 +66,9 @@ export default class Font {
     );
   }
 
-  getNoScriptCSSText({ usedFontaine = false } = {}) {
+  getNoScriptCSSText() {
     const selector = createSelector(this.rootSelector, this.selector);
-    const family = prepareFamily(this.family, { usedFontaine });
+    const family = `"${this.family}"`;
     return wrapByMedia(
       `${selector} {
         font-family: ${[family].concat(this.fallbackFamily).join(', ')};
@@ -123,9 +125,9 @@ function weightNormalize(weight) {
   }
 }
 
-function prepareFamily(family, { usedFontaine = false } = {}) {
-  if (!usedFontaine) {
-    return `"${family}"`;
+function getFontaineFallback(family, usedFontaine) {
+  if (usedFontaine) {
+    return `"${family} fallback"`;
   }
-  return `"${family}", "${family} fallback"`;
+  return '';
 }
diff --git a/src/runtime/classes/FontCollection.mjs b/src/runtime/classes/FontCollection.mjs
@@ -50,10 +50,10 @@ export default class FontCollection {
     ]);
   }
 
-  getNoScriptStyleDescriptions(options) {
+  getNoScriptStyleDescriptions() {
     return getRelevantDescriptions([
       getStyleDescription(
-        this.list.map(font => font.getNoScriptCSSText(options)).join(' '),
+        this.list.map(font => font.getNoScriptCSSText()).join(' '),
         true
       )
     ]);

diff --git a/src/runtime/composables/fonts.mjs b/src/runtime/composables/fonts.mjs
@@ -40,7 +40,7 @@ function writeHead(isCritical, fontCollection, runtimeConfig) {
       return fontCollection.getStyleDescriptions(options);
     }),
     noscript: computed(() => {
-      return fontCollection.getNoScriptStyleDescriptions(options);
+      return fontCollection.getNoScriptStyleDescriptions();
     })
   });
 }