fix(node-cache): removed node-cache

basics · Nov 1, 2024 · a3afce2 · a3afce2
1 parent 446fd47
commit a3afce2
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 49 deletions.
diff --git a/docs/src/guide/options.md b/docs/src/guide/options.md
@@ -274,22 +274,6 @@ Global option for the [`IntersectionObserver`](https://developer.mozilla.org/en-
  | `component` | `String` | yes      | [`rootMargin`](https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver/rootMargin) value for [`BoosterHydrate`](/guide/usage#import-components).                  | `0%`    |
  | `asset`     | `String` | yes      | [`rootMargin`](https://developer.mozilla.org/en-US/docs/Web/API/IntersectionObserver/rootMargin) value for all static ressources (`v-font`, `BoosterPicture` & `BoosterImage`). | `0%`    |
 
-## `imageSizeCache`
-
-- Type: `Object`
-  - Default: `{ stdTTL: 3600, checkperiod: 1800 }`
-
-The `imageSizeCache` option is used to cache the image sizes of the `BoosterImage` and `BoosterPicture` components. This reduces the number of requests to the server and speeds up the loading process.
-
-Learn more about the options in the [node-cache documentation](https://www.npmjs.com/package/node-cache#options).
-
-````js
-{
-  stdTTL: 3600,
-  checkperiod: 1800
-}
-````
-
 ## `disableNuxtFontaine`
 
 - Type: `Boolean`

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -61,7 +61,6 @@
     "htmlparser2": "9.1.0",
     "image-meta": "0.2.1",
     "mime-types": "2.1.35",
-    "node-cache": "5.1.2",
     "pathe": "1.1.2",
     "sort-css-media-queries": "2.4.0"
   },

diff --git a/src/module.js b/src/module.js
@@ -120,8 +120,7 @@ async function addBuildTemplates(nuxt, options) {
           targetFormats: options.targetFormats,
           crossorigin: getCrossorigin(options.crossorigin),
           supportedBrowserDetector,
-          loader: options.loader,
-          imageSizeCache: options.imageSizeCache
+          loader: options.loader
         });
       },
       filename: MODULE_NAME + `/plugin.${mode}.js`,

diff --git a/src/tmpl/plugin.tmpl.js b/src/tmpl/plugin.tmpl.js
@@ -6,12 +6,6 @@ import FontList from '#booster/classes/FontList';
 import { useNuxtApp, useBoosterHead, useRequestHeaders, useRequestURL, useRequestFetch } from '#imports';
 import './fonts.css';`;
 
-  if (options.mode !== 'client') {
-    code += `
-import NodeCache from 'node-cache';
-`;
-  }
-
   code += `
 
 export default defineNuxtPlugin({
@@ -54,15 +48,9 @@ export default defineNuxtPlugin({
 
 `;
 
-  if (options.mode === 'client') {
-    code += `
-const dimensionCache = new Map();`;
-  } else {
-    code += `
-const dimensionCache = new NodeCache({  useClones: false, ...${JSON.stringify(options.imageSizeCache)} });`;
-  }
-
   code += `
+const dimensionCache = new Map();
+
 async function getImageSize (src) {
 `;
 

diff --git a/src/utils/options.js b/src/utils/options.js
@@ -39,13 +39,17 @@ export function getDefaultOptions() {
     lazyOffset: {
       component: '0%',
       asset: '0%'
-    },
-
-    imageSizeCache: { stdTTL: 3600, checkperiod: 1800 }
+    }
   };
 }
 
 export function deprecationsNotification(options) {
+  if ('imageSizeCache' in options) {
+    logger.warn(
+      'Option `imageSizeCache` is deprecated, is no longer required.'
+    );
+    delete options.loader;
+  }
   if ('loader' in options) {
     logger.warn(
       'Option `loader` is deprecated, there is no integrated loader anymore.'