Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ppc64le architecture support on travis-ci #81

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

kishorkunal-raj
Copy link
Contributor

Hi,
I had added ppc64le(Linux on Power) architecture support on travis-ci in the PR and looks like its been successfully added. I believe it is ready for the final review and merge. The travis ci build logs can be verified from the link below.
https://www.travis-ci.com/github/kishorkunal-raj/base62.js/builds/209329352

Reason behind running tests on ppc64le: This package is included in the ppc64le versions of RHEL and Ubuntu - this allows the top of tree to be tested continuously as it is for Intel, making it easier to catch any possible regressions on ppc64le before the distros begin their clones and builds. This reduces the work in integrating this package into future versions of RHEL/Ubuntu.

Please have a look.

Regards,
Kishor Kunal Raj

@FND
Copy link
Collaborator

FND commented Dec 17, 2020

Thanks for this, @kishorkunal-raj! I took the opportunity to migrate to GitHub Actions in #82 - but that seems to fail for non-obvious reasons. I'll take a closer look again soon (hopefully), but would welcome any assistance.

(Sorry for pinging you via multiple force-pushes there; debugging SaaS YAML can be tricky... )

@kishorkunal-raj
Copy link
Contributor Author

Thanks for reviewing the PR and I am happy to know that you opted to migrate to github actions. As currently the ppc64le architecture is not yet supported on github actions, so it may be one of the reasons its failing. Also for information we do have plan to support ppc64le on github actions in our pipeline and team is working on it, so soon the architecture will be available there. Thanks again

@kishorkunal-raj
Copy link
Contributor Author

Also to bring into notice that Travis is not yet dead. Travis.org is now moved to travis.com and is pretty much widely being used across the open source communities

@FND
Copy link
Collaborator

FND commented Dec 18, 2020

Oh, well, if GitHub Actions doesn't yet support ppc64le, that explains the failures... (Though I would never have guessed that based on the error output.)

In that case, I'll go ahead and merge this now (and opt not to comment further on the complex politics of Travis CI) while we wait for ppc64le support on GitHub Actions. I'd appreciate if you could ping me once that happens so we can merge #82 then.

@FND FND merged commit 72a89c5 into base62:master Dec 18, 2020
@kishorkunal-raj
Copy link
Contributor Author

kishorkunal-raj commented Dec 18, 2020

Oh, well, if GitHub Actions doesn't yet support ppc64le, that explains the failures... (Though I would never have guessed that based on the error output.)

In that case, I'll go ahead and merge this now (and opt not to comment further on the complex politics of Travis CI) while we wait for ppc64le support on GitHub Actions. I'd appreciate if you could ping me once that happens so we can merge #82 then.

Once the ppc architecture is enabled on github actions, I will definitely let you know. Thanks for merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants