Fix duplicate forex quotes (^EURUSD and ^USDEUR). Eliminate duplicate…

… refreshes (in some cases)

.releases/1.27.2.md

@@ -0,0 +1,5 @@
+**Bug Fixes**
+
+* Corrected failure to translate currencies by preventing two `Rate` objects, which represent same currency pair, from existing in the `PositionContainer` (e.g. ^EURUSD and ^USDEUR).
+* Eliminated multiple unnecessary calls to the `PositionGroup.setForexRates` function.
+* Eliminated multiple unnecessary calls to the `PositionContainer.refresh` function.

lib/processing/PositionContainer.js

@@ -583,21 +583,28 @@ module.exports = (() => {
 
 					if (symbol) {
 						const rate = Rate.fromPair(quote.lastPrice, symbol);
-						const index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
+
+						let index = this._forexQuotes.findIndex(existing => existing.formatPair() === rate.formatPair());
+
+						if (index < 0) {
+							const inverted = rate.invert();
+
+							index = this._forexQuotes.findIndex(existing => existing.formatPair() === inverted.formatPair());
+						}
 
 						if (index < 0) {
 							this._forexQuotes.push(rate);
 						} else {
 							this._forexQuotes[index] = rate;
 						}
 
-						Object.keys(this._trees).forEach((key) => {
-							this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false);
-						});
-
 						recalculatePercentages.call(this);
 					}
 				});
+
+				Object.keys(this._trees).forEach((key) => {
+					this._trees[key].walk(group => group.setForexRates(this._forexQuotes), true, false);
+				});
 			}
 
 			if (positionQuotes.length !== 0 || forexQuotes.length !== 0) {