js: Improved null/undefined/NaN handling in rapidcontext.data.compare()

baraverkstad · Dec 7, 2024 · 67191c9 · 67191c9
1 parent 169f5ce
commit 67191c9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/plugin/system/files/js/rapidcontext/data.mjs b/src/plugin/system/files/js/rapidcontext/data.mjs
@@ -17,7 +17,7 @@
  * @namespace RapidContext.Data
  */
 
-import { isNil, isFunction, isObject, isArrayLike, isIterable, hasProperty, hasValue } from './fn.mjs';
+import { isNil, isFunction, isNumber, isObject, isArrayLike, isIterable, hasProperty, hasValue } from './fn.mjs';
 
 const OFF = ['null', 'undefined', '0', 'f', 'false', 'off', 'n', 'no'];
 
@@ -380,7 +380,13 @@ export function compare(valueOf, a, b) {
         a = valueOf(a);
         b = valueOf(b);
     }
-    return a < b ? -1 : (a > b ? 1 : 0);
+    let aNil = isNil(a) || (isNumber(a) && isNaN(a));
+    let bNil = isNil(b) || (isNumber(b) && isNaN(b));
+    if (aNil || bNil) {
+        return (aNil && bNil) ? 0 : (aNil ? -1 : 1);
+    } else {
+        return (a < b) ? -1 : (a > b ? 1 : 0);
+    }
 }
 
 /**

diff --git a/test/src/js/rapidcontext/data.test.mjs b/test/src/js/rapidcontext/data.test.mjs
@@ -195,10 +195,14 @@ test('data.uniq()', () => {
 
 test('data.compare()', () => {
     assert.strictEqual(data.compare(null, undefined), 0);
+    assert.strictEqual(data.compare(null, NaN), 0);
     assert.strictEqual(data.compare(undefined, null), 0);
+    assert.strictEqual(data.compare(undefined, NaN), 0);
     assert.strictEqual(data.compare(1, 1), 0);
     assert.strictEqual(data.compare(1, 42), -1);
-    assert.strictEqual(data.compare(1, NaN), 0);
+    assert.strictEqual(data.compare(1, NaN), 1);
+    assert.strictEqual(data.compare(null, 1), -1);
+    assert.strictEqual(data.compare('', 'abc'), -1);
     assert.strictEqual(data.compare('abc', 'abc'), 0);
     assert.strictEqual(data.compare('abc', 'cde'), -1);
     assert.strictEqual(data.compare('cde', 'abc'), 1);