fix: use the stable chart appVersion as image tag by default (opensea…

…rch-project#17) Using :latest by default is going to lead to clusters with version skew as pods schedule onto new nodes. So use a stable tag instead. Signed-off-by: Scott Leggett <[email protected]>
banzaicloud · Jul 29, 2021 · a2a2d8b · a2a2d8b
1 parent c1eac61
commit a2a2d8b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/Helm/opensearch/templates/statefulset.yaml b/Helm/opensearch/templates/statefulset.yaml
@@ -167,7 +167,7 @@ spec:
       initContainers:
 {{ if .Values.keystore }}
       - name: keystore
-        image: "{{ .Values.image }}:{{ .Values.imageTag }}"
+        image: "{{ .Values.image }}:{{ .Values.imageTag | default .Chart.AppVersion }}"
         imagePullPolicy: "{{ .Values.imagePullPolicy }}"
         command:
         - sh
@@ -217,7 +217,7 @@ spec:
       - name: "{{ template "opensearch.name" . }}"
         securityContext:
 {{ toYaml .Values.securityContext | indent 10 }}
-        image: "{{ .Values.image }}:{{ .Values.imageTag }}"
+        image: "{{ .Values.image }}:{{ .Values.imageTag | default .Chart.AppVersion }}"
         imagePullPolicy: "{{ .Values.imagePullPolicy }}"
         ports:
         - name: http
@@ -336,7 +336,7 @@ spec:
       {{- if eq .Values.roles.master "true" }}
       # This sidecar will prevent slow master re-election
       - name: opensearch-master-graceful-termination-handler
-        image: "{{ .Values.image }}:{{ .Values.imageTag }}"
+        image: "{{ .Values.image }}:{{ .Values.imageTag | default .Chart.AppVersion }}"
         imagePullPolicy: "{{ .Values.imagePullPolicy }}"
         command:
         - "sh"

diff --git a/Helm/opensearch/values.yaml b/Helm/opensearch/values.yaml
@@ -96,7 +96,8 @@ hostAliases: []
 #  - "bar.local"
 
 image: "opensearchproject/opensearch"
-imageTag: "latest"
+# override image tag, which is .Chart.AppVersion by default
+imageTag: ""
 imagePullPolicy: "IfNotPresent"
 
 podAnnotations: {}