Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vmin/vmax #199

Merged
merged 5 commits into from
Feb 10, 2024
Merged

Fix vmin/vmax #199

merged 5 commits into from
Feb 10, 2024

Conversation

banesullivan
Copy link
Owner

Resolve #198

cc @giswqs

I think this does it. Will test with fresh eyes tomorrow

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2d747d1) 83.08% compared to head (5c00f8d) 83.62%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
+ Coverage   83.08%   83.62%   +0.54%     
==========================================
  Files          26       26              
  Lines        1011     1020       +9     
==========================================
+ Hits          840      853      +13     
+ Misses        171      167       -4     

@banesullivan banesullivan merged commit 3b46d9e into main Feb 10, 2024
8 checks passed
@banesullivan banesullivan deleted the patch/vmin-vmax branch February 10, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The vmin and vmax parameters have no effect
2 participants