Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSS] Implement to support request feeds signature #7

Merged
merged 13 commits into from
Jun 6, 2024

Conversation

satawatnack
Copy link
Member

@satawatnack satawatnack commented May 27, 2024

Implementation details

  • change tx msg from oracletypes.MsgRequestData to sdk.Msg
  • add feeds watcher to support feeds signature
  • add retry request signature

Todo

  • add feeds watcher to support feeds signature
  • handle estimate gas doesn't work with bandtsstypes.MsgRequestSignature

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

@satawatnack satawatnack changed the title Implement to support request feeds signature [TSS] Implement to support request feeds signature May 27, 2024
@satawatnack satawatnack marked this pull request as ready for review May 28, 2024 07:24
@satawatnack satawatnack requested review from nkitlabs and RogerKSI May 28, 2024 07:24
@RogerKSI RogerKSI requested a review from taobun June 3, 2024 14:21
@nkitlabs nkitlabs merged commit 9a612c1 into tss-support-signature Jun 6, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants