New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetQuery compat with newer Trino #18

Open

naushadh wants to merge 1 commit into bamcis-io:vNext from naushadh:fix-get-query

naushadh commented Sep 29, 2022 •

edited

Loading

With #16 merged, thought this would be the time to review and merge fixes for the current CI failure.

See CI results here: https://github.com/naushadh/PrestoClient/actions/runs/3147904134/jobs/5117875501

Failure here appears to be caused by missing Docker hub login credentials in Github secrets: https://docs.github.com/en/actions/security-guides/encrypted-secrets

If we could add DOCKER_USER and DOCKER_PASS with values from personal/company Dockerhub account to this repo, CI should pass. See https://docs.docker.com/docker-hub/access-tokens/


          Fix GetQuery compat with newer Trino

0ada10c

When invoking `GetQuery`, especially by the test cases `TestGetQuery`, there are several JSON de-serialization errors that occur due to many API attributes that have been renamed, removed or updated.

- Update DistributionSnapshot.cs to adopt upstream change from long to double, see airlift/airlift@cbd87fb#diff-5970d721c9fdedf83b670731eeb39c94ff187390c89b6ba5d0a23e3b7826ee2aL198.

- Rename ConnectorId.cs to CatalogHandle.cs to adopt upstream rename of ConnectorId to CatalogHandle, see trinodb/trino@78383a9 and trinodb/trino@44e6917#diff-75d8d8d5569d29ee5c515cabb8808cc6b6a659eba236b861dbb5ef29837a794c. Update SessionRepresentation.cs, Output.cs, Input.cs, IndexHandle.cs, TableHandle.cs, PartitioningHandle to update references.

- Update Input.cs to adopt upstream change of unwrapping CatalogHandle into CatalogName, see trinodb/trino@282475a#diff-b6734410d395c5e3035382626ea23ca88bce34b3bac53ee82cc7cf38c29bc91c

- Remove Lifespan.cs since upstream has removed it, see trinodb/trino@ced7c97. Update TaskStatus.cs to drop references.

- Remove MemoryPoolId.cs since upstream has removed it, see trinodb/trino@698ff6c. Update BasicQueryInfo.cs, QueryInfo.cs to drop references.

- Update StageInfo.cs to adopt upstream change of dropping `Self`, see trinodb/trino@118d1a1#diff-2ddf1c0480dcccdd6d136cfdf554041ed1069e110439f67ae2de2e5cc4d1b445

- Update StageStrats.cs to adopt upstream change to dropping ScheduleTaskDistribution and AddSplitDistribution, see trinodb/trino@4fe2f45#diff-b53bb4abb0657e165761f1a50c67a830b6ca546c2fdc234f00c0d3dafc70042a

- Update TaskStatus.cs, DriverStats.cs, OperatorStats.cs, PipelineStats.cs, TaskStats.cs to adopt upstream change of dropping SystemMemoryReservation, see https://github.com/trinodb/trino/pull/10574/files#diff-9352c85a79f6936e58ca8bb304c66504828c8142be083d5c1a7d81b2f39378c6

- Update TaskStatus.cs to switch NodeId from GUID to String since upstream models it this way, see trinodb/trino@1a81623

- Remove TableLayoutHandle.cs since upstream has removed it, see trinodb/trino@deff7b1. Update IndexSourceNode.cs, MetadataDeleteNode, TableScanNode.cs to drop references.

- Update IndexSourceNode.cs, TableScanNode.cs to drop CurrentConstraint since upstream has dropped it, see trinodb/trino@aba0c3f#diff-939ee99f20a64a093eba421145798743c2d264ac32fcddf79c881955d520e492, trinodb/trino@b1d1e9c#diff-4df7a2f0869b2187f4678d9fc846beb078244b9bd9d0f0007797c1641c43dc9f

- Update PrestoClient.csproj to limit TargetFrameworks so suppress test failure caused by missing developer packs for 4.6.1 and 5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet