Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qidi.json #5056

Merged
merged 8 commits into from
Oct 30, 2024
Merged

Qidi.json #5056

merged 8 commits into from
Oct 30, 2024

Conversation

HYzd766
Copy link
Contributor

@HYzd766 HYzd766 commented Oct 21, 2024

new machine

@QingZhangBambu
Copy link
Collaborator

image
这个custom gcode的挤出线是你们想要的吗？看上去比较奇怪。请确认一下。

@QingZhangBambu
Copy link
Collaborator

@HYzd766 你提交的文件有行尾有很多多余的空格。清除一下

@HYzd766
Copy link
Contributor Author

HYzd766 commented Oct 30, 2024

image 这个custom gcode的挤出线是你们想要的吗？看上去比较奇怪。请确认一下。

我这边切片出来都是正常的实线不是虚线

@QingZhangBambu
Copy link
Collaborator

@HYzd766 看上去像虚线是因为摩尔纹。这条挤出线是需要的就可以。请清除一下多余的行尾空格。

@HYzd766
Copy link
Contributor Author

HYzd766 commented Oct 30, 2024

@HYzd766 你提交的文件有行尾有很多多余的空格。清除一下

你好行尾多余空格具体指的什么，可以举例我去清除一下吗

@QingZhangBambu
Copy link
Collaborator

image
例如这个

@QingZhangBambu
Copy link
Collaborator

以下文件都有多余的空格
resources/profiles/Qidi.json
resources/profiles/Qidi/filament/QIDI ABS-GF @Qidi X-Plus 4 0.4 nozzle.json
resources/profiles/Qidi/filament/QIDI ABS-GF @Qidi X-Plus 4 0.6 nozzle.json
resources/profiles/Qidi/filament/QIDI ABS-GF @Qidi X-Plus 4 0.8 nozzle.json
resources/profiles/Qidi/machine/fdm_qidi_x3_common.json
resources/profiles/Qidi/machine/fdm_qidi_x3_common.json

@HYzd766
Copy link
Contributor Author

HYzd766 commented Oct 30, 2024

image 例如这个

不好意思我没懂，我这是格式就是这样摆放吗

@QingZhangBambu
Copy link
Collaborator

image
zhe'g这个是空格，只是我的这边的显示成了橘色。你打开vs是能看到空格标识的。把这种不必要的行末空格去除一下

@HYzd766
Copy link
Contributor Author

HYzd766 commented Oct 30, 2024

image zhe'g这个是空格，只是我的这边的显示成了橘色。你打开vs是能看到空格标识的。把这种不必要的行末空格去除一下

好的，我发现了

QingZhangBambu
QingZhangBambu approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@QingZhangBambu QingZhangBambu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass filament id and setting id test, sub path check, and could work properly

@lanewei120 lanewei120 merged commit 869ee72 into bambulab:master Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QingZhangBambu QingZhangBambu QingZhangBambu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HYzd766 @QingZhangBambu @lanewei120