Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Creality 3D Printer Models K1 and K1 Max #2914

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Add Support for Creality 3D Printer Models K1 and K1 Max #2914

merged 3 commits into from
Dec 8, 2023

Conversation

iZonex
Copy link
Contributor

@iZonex iZonex commented Nov 17, 2023 •
edited
Loading

Add Support for Creality 3D Printer Models K1 and K1 Max

Screenshot 2023-11-18 at 00 49 47 Screenshot 2023-11-18 at 00 49 30 Screenshot 2023-11-18 at 00 49 47 Screenshot 2023-11-18 at 14 09 05

Introduction

This pull request integrates support for two new Creality 3D printer models: K1 and K1 Max into Bambu Studio for software, enhancing our range of compatible devices.

New Additions

Core Updates

  • Cover Images: Creality K1_cover.png, Creality K1 Max_cover.png
  • Buildplate Models and Textures:
    • creality_k1_buildplate_model.stl
    • creality_k1max_buildplate_model.stl
    • creality_k1_buildplate_texture.png
    • creality_k1max_buildplate_texture.png
  • Machine-Specific Profiles:
    • Creality K1 0.4 nozzle.json
    • Creality K1 Max 0.4 nozzle.json
    • Creality K1 Max.json
    • Creality K1.json
  • Process Profiles:
    • 0.16mm Optimal @Creality 0.4 K1.json
    • 0.20mm Standard @Creality 0.4 K1Max.json
    • and others for different print qualities

Modifications

Enhanced Compatibility

  • resources/profiles/Creality.json
  • resources/profiles/Creality/filament/Generic ABS @Creality.json
  • resources/profiles/Creality/filament/Generic PETG @Creality.json
  • resources/profiles/Creality/filament/Generic PLA @Creality.json
  • src/slic3r/GUI/CreatePresetsDialog.cpp

Rationale

Incorporating the K1 and K1 Max models aligns with our goal of keeping our software current and accommodating a broader range of 3D printing technologies.

Testing

Comprehensive testing ensures these profiles provide the best experience for K1 and K1 Max users.

@iZonex iZonex marked this pull request as ready for review November 17, 2023 22:59
@iZonex
Copy link
Contributor Author

iZonex commented Nov 22, 2023

@lanewei120 We can add this to 1.8? I already tested on my K1/K1 Max printer, working ok, only one problem with thumbnails what was fixed in Orca Fork, but this issue not related to profile for K1/K1 Max

@lanewei120
Copy link
Collaborator

@SaltWei @XunZhangBambu please review

XunZhangBambu
XunZhangBambu requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@XunZhangBambu XunZhangBambu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying these commits, I also found that the memory usage becomes very high when switching the printer to K1 and K1 Max.

resources/profiles/Creality.json Outdated
"sub_path": "process/0.20mm Standard @Creality 0.4 K1.json"
},
{
"name": "0.20mm Standard @Creality 0.4 K1Max",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to name it as "xxx @creality K1Max 0.4 nozzle"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Was renamed by yours pattern

resources/profiles/Creality/machine/Creality K1 Max 0.4 nozzle.json Outdated
"change_filament_gcode": "",
"machine_pause_gcode": "PAUSE",
"default_filament_profile": [
"Creality Generic PLA"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Generic PLA @creality

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, Thanks! You found! Fixed

resources/profiles/Creality/machine/Creality K1 0.4 nozzle.json Outdated
"change_filament_gcode": "",
"machine_pause_gcode": "PAUSE",
"default_filament_profile": [
"Creality Generic PLA"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be Generic PLA @creality

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed!

@iZonex iZonex requested a review from XunZhangBambu November 30, 2023 20:31
@iZonex
Copy link
Contributor Author

iZonex commented Nov 30, 2023

Screenshot 2023-11-30 at 22 25 01 Screenshot 2023-11-30 at 22 24 54

@iZonex
Copy link
Contributor Author

iZonex commented Nov 30, 2023 •
edited
Loading

After applying these commits, I also found that the memory usage becomes very high when switching the printer to K1 and K1 Max.

Optimized sizes of stl and png files for plate and texture K1, K1 Max

K1 STL 316 KB -> 158 KB
K1 MAX STL 512 KB -> 145 KB

@iZonex
Copy link
Contributor Author

iZonex commented Dec 4, 2023

@XunZhangBambu Now all ok?

@XunZhangBambu
Copy link
Contributor

XunZhangBambu commented Dec 5, 2023 •
edited
Loading

@iZonex Sorry,I still find the memory usage becomes extremely high
20231205100939_rec_

@iZonex
Copy link
Contributor Author

iZonex commented Dec 5, 2023

@iZonex Sorry,I still find the memory usage becomes extremely high 20231205100939_rec_ 20231205100939_rec_

Now I used simple version of build plates working much faster.

@iZonex
Copy link
Contributor Author

iZonex commented Dec 5, 2023

Screen.Recording.2023-12-05.at.11.37.30.mov

@XunZhangBambu
Copy link
Contributor

@iZonex I tried again, but encountered an error while loading the STL. And I believe that just a STL file shouldn't result in such high memory usage

@iZonex
Copy link
Contributor Author

iZonex commented Dec 6, 2023

@iZonex I tried again, but encountered an error while loading the STL. And I believe that just a STL file shouldn't result in such high memory usage

What error appeared?

@XunZhangBambu
Copy link
Contributor

@iZonex After testing again ,that's my problem. Now I think this pull request can be merged. Excellent work ! Thanks very much for your efforts!

@iZonex
Copy link
Contributor Author

iZonex commented Dec 8, 2023

@lanewei120 Please merge, Thanks!

@lanewei120 lanewei120 merged commit 9d1cdea into bambulab:master Dec 8, 2023
2 checks passed
This was referenced Dec 8, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XunZhangBambu XunZhangBambu XunZhangBambu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iZonex @lanewei120 @XunZhangBambu