[Master] Add Semtype implementation for jballerina #43671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #35886 has been addressed, we should be able to remove the temporary shape check workaround. Please refer to #35872 (comment)
Previously ballerina `readonly` return type allowed for java void methods. However, `error?` was not allowed with java void. This inconsistency is due to type checking not recognizing the fact that readonly type does include the error type. The error given in the latter case too is wrong because error is optional.
Previously this was implemented with a temporary workaround which was inefficient as we recalculated the semtypes.
Please refer to #43344 (comment) for the reason
Rewrite BUnionType's `getMemberTypes()` usages using SemTypes
# Conflicts: # .github/workflows/pull_request_full_build.yml # .github/workflows/pull_request_ubuntu_build.yml # .github/workflows/pull_request_windows_build.yml # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmTerminatorGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/ModuleStopMethodGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/values/JvmObjectGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Sync nutcracker branch for java 21 changes
This will fix the ModuleExecutionFlowTests tests failures on top of the semtype runtime changes. My guess is now that runtime faster with semtypes, a faster reading rate is required.
…ina-lang into nutcracker_new
…llerina-lang into nutcracker_new # Conflicts: # tests/ballerina-test-utils/src/main/java/org/ballerinalang/test/context/ServerLogReader.java
This reverts commit 72eb483.
gimantha
requested review from
MaryamZi,
KavinduZoysa,
warunalakshitha,
azinneera,
NipunaRanasinghe,
sameerajayasoma and
hasithaa
as code owners
gimantha
added
the
Team/CompilerFE
|
Comment on lines
-7
to
+8
|
|
||
| - java21 | ||
| - nutcracker |
There was a problem hiding this comment.
Do we still need these branches? Cant we remove them from the workflows?
There was a problem hiding this comment.
yes. will remove them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #40474
Approach
Samples
Remarks
Check List