Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLite jdbc dependency to the distribution #43646

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

nipunayf
Copy link
Contributor

Purpose

Add the sqlite-jdbc dependency to the distribution, as it is required for the LS extension of the Ballerina integrator.

Fixes ballerina-platform/ballerina-distribution#5811

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@nipunayf nipunayf requested a review from keizer619 as a code owner November 25, 2024 06:01
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (4330bae) to head (f1b5795).
Report is 80 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #43646      +/-   ##
============================================
- Coverage     77.47%   77.40%   -0.08%     
- Complexity    58515    58580      +65     
============================================
  Files          3434     3445      +11     
  Lines        218698   219048     +350     
  Branches      28919    28960      +41     
============================================
+ Hits         169441   169546     +105     
- Misses        39858    40083     +225     
- Partials       9399     9419      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nipunayf nipunayf merged commit ed07a3f into ballerina-platform:master Dec 4, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the org.xerial:sqlite-jdbc JAR to the distribution
2 participants