Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending semtype changes to master #43606

Open
wants to merge 983 commits into
base: 2201.11.0-stage
Choose a base branch
from
Open

Conversation

lochana-chathura
Copy link
Member

@lochana-chathura lochana-chathura commented Nov 19, 2024

Purpose

$subject.

Fixes #40474

Approach

n/a

Samples

n/a

Remarks

n/a

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Previously this was implemented with a temporary workaround which was inefficient as we recalculated the semtypes.
 Rewrite BUnionType's `getMemberTypes()` usages using SemTypes
# Conflicts:
#	.github/workflows/pull_request_full_build.yml
#	.github/workflows/pull_request_ubuntu_build.yml
#	.github/workflows/pull_request_windows_build.yml
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmTerminatorGen.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/ModuleStopMethodGen.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/values/JvmObjectGen.java
#	compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Sync nutcracker branch for java 21 changes
@lochana-chathura lochana-chathura added Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Area/SemtypeIntegration Issue related to integrating semtype engine labels Nov 19, 2024
warunalakshitha and others added 2 commits November 21, 2024 19:56
Disable `workerVariableVisibilityTest ` debugger test
This will fix the ModuleExecutionFlowTests tests failures on top of the semtype runtime changes. My guess is now that runtime faster with semtypes, a faster reading rate is required.
@gimantha gimantha changed the base branch from master to 2201.11.0-stage November 25, 2024 05:47
@gimantha gimantha changed the base branch from 2201.11.0-stage to master November 25, 2024 05:57
@gimantha gimantha changed the base branch from master to 2201.11.0-stage November 25, 2024 06:08
@gimantha gimantha changed the base branch from 2201.11.0-stage to master November 25, 2024 06:16
@HindujaB HindujaB added this to the 2201.11.0 milestone Nov 25, 2024
@gimantha gimantha changed the base branch from master to 2201.11.0-stage November 26, 2024 05:19
@gimantha gimantha closed this Dec 3, 2024
@gimantha gimantha reopened this Dec 3, 2024
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.2% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/SemtypeIntegration Issue related to integrating semtype engine Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Integrate nBallerina type engine into jBallerina
7 participants