-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending semtype changes to master #43606
Open
lochana-chathura
wants to merge
983
commits into
2201.11.0-stage
Choose a base branch
from
nutcracker
base: 2201.11.0-stage
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+39,865
−14,577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was implemented with a temporary workaround which was inefficient as we recalculated the semtypes.
Please refer to #43344 (comment) for the reason
Rewrite BUnionType's `getMemberTypes()` usages using SemTypes
# Conflicts: # .github/workflows/pull_request_full_build.yml # .github/workflows/pull_request_ubuntu_build.yml # .github/workflows/pull_request_windows_build.yml # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmTerminatorGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/ModuleStopMethodGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/split/values/JvmObjectGen.java # compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Sync nutcracker branch for java 21 changes
lochana-chathura
added
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Area/SemtypeIntegration
Issue related to integrating semtype engine
labels
Nov 19, 2024
Disable `workerVariableVisibilityTest ` debugger test
Set span status code
lochana-chathura
force-pushed
the
nutcracker
branch
from
November 22, 2024 10:27
54adcc3
to
ac28a08
Compare
This will fix the ModuleExecutionFlowTests tests failures on top of the semtype runtime changes. My guess is now that runtime faster with semtypes, a faster reading rate is required.
lochana-chathura
force-pushed
the
nutcracker
branch
from
November 22, 2024 11:03
ac28a08
to
7a51dad
Compare
Merge `flow_model` into `master`
…ina-lang into nutcracker_new
…llerina-lang into nutcracker_new # Conflicts: # tests/ballerina-test-utils/src/main/java/org/ballerinalang/test/context/ServerLogReader.java
gimantha
approved these changes
Dec 2, 2024
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area/SemtypeIntegration
Issue related to integrating semtype engine
Team/CompilerFE
All issues related to Language implementation and Compiler, this exclude run times.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject.
Fixes #40474
Approach
n/a
Samples
n/a
Remarks
n/a
Check List