Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved config to yaml, remove unused tests #368

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fritjof-b
Copy link
Contributor

This is a big PR, moving the configuration to YAML in the root of the project. This config then gets copied when you create a new project using --newProject. The config file itself might need some refinement.

Breaking: If you're currently using a config.py, you need to translate it to <project_name>_config.yaml, and store it in the same location as your previous python configuration.

For reviewers: Please check out the branch and run your models, and plotting before approving.

@fritjof-b fritjof-b requested review from exook and gallenaxel March 7, 2024 13:37
@gallenaxel
Copy link
Contributor

Starting a checklist to see what works and not:
works

  • CFD animation with updated config file
  • CMS Project v1 with updated config file

doesn't work

  • config file needs input_path: "" which points to the workspace/<workspace_name>/data/<workspace_name_data>.npz file

  • CDF still animation (not sure if this one worked before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants