Switch to no-systemd variant of open-balena-base #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
kyle/no-systemd
branch
from
9c5aa44
to
b7d2649
Compare
klutchell
force-pushed
the
kyle/no-systemd
branch
2 times, most recently
from
8f6d03a
to
7e30725
Compare
joshbwlng
reviewed
Aug 1, 2024
Dockerfile
Outdated
|
|
||
| EXPOSE 80 | ||
| EXPOSE 81 | ||
| FROM balena/open-balena-base:v18.0.8-no-systemd | ||
|
|
||
| # hadolint ignore=DL3008 | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| musl \ |
There was a problem hiding this comment.
Do we still need musl? I was able to build the image locally with this entire RUN step removed so wanted to double-check.
There was a problem hiding this comment.
Good catch @joshbwlng! That requirement was dropped in registry 2.7.0.
Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
This cointainer only runs a single service and running systemd requires a lot of overhead and extra permissions. Change-type: minor Signed-off-by: Kyle Harding <[email protected]>
Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/no-systemd
branch
from
7e30725
to
ab4f6e2
Compare
We added musl in commit e0daae8 as it was required by registry 2.5.0. In registry 2.7.0 they enabled CGO_ENABLED=0 via commit distribution/distribution@8a800e1 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/no-systemd
branch
from
ab4f6e2
to
2cb2e43
Compare
ab77
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: https://github.com/balena-io/environment-staging/pull/3894
Requires: https://github.com/balena-io/environment-production/pull/2607
See: https://balena.fibery.io/Inputs/Pattern/balenaCloud-systemd-based-components-cannot-run-on-hosts-with-cgroups-v2-4067
See: https://balena.fibery.io/Work/Improvement/Remove-systemd-from-open-balena-registry-2019