This repository has been archived by the owner on Aug 13, 2021. It is now read-only.
Handling Oracle's missing ILIKE operator #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oracle does not have the ILIKE operator, which makes the pure usage of `wlNext.caseSensitive` flag not possible. Here's what I found out and what my change is based on. Setting `wlNext.caseSensitive: true` produces a plain LIKE query, which makes perfect sense. Setting `wlNext.caseSensitive: false` produces an ILIKE query with the LOWER wrap, which is a bit confusing to me, because the ILIKE is case-insensitive, and therefore there should be no need for LOWER. Never the less, this case throws an error when using with Oracle, because Oracle does not have the ILIKE operator. My solution above was twofold. First, I fixed the DRY violation on the `wlNext.caseSensitive` flag checking. Second, I added a new flag `wlNext.forceLike` with which one can indicate that the database requires LIKE to be used, instead of ILIKE.
Fixing the missing )
fixing accidental new line :(
I need coffee...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle does not have the ILIKE operator, which makes the pure usage of
wlNext.caseSensitiveflag not possible.Here's what I found out and what my change is based on. Setting
wlNext.caseSensitive: trueproduces a plain LIKE query, which makes perfect sense.Setting
wlNext.caseSensitive: falseproduces an ILIKE query. This case throws an error when using with Oracle, because Oracle does not have the ILIKE operator.My solution above was twofold. First, I fixed the DRY violation on the
wlNext.caseSensitiveflag checking. Second, I added a new flagwlNext.forceLikewith which one can indicate that the database requires LIKE to be used, instead of ILIKE.