You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing issue with some pools thinking they're in recovery mode
Fixing edge cases with APR's / pool info.
Fix/Remove test cases
Type of change
New feature (non-breaking change which adds functionality)
How should this be tested?
Compare this branch to production, all pools lists and individual pool pages should look roughly the same. Some dollar values may be different due to the pricing being calculated at slightly different times.
Checklist:
I have performed a self-review of my own code
I have requested at least 1 review (If the PR is significant enough, use best judgement here)
I have commented my code where relevant, particularly in hard-to-understand areas
If package-lock.json has changes, it was intentional.
The base of this PR is master if hotfix, develop if not
Some sub-pools like Phantom Stable don't have a mainIndex. In the
subgraph this is set to null (even though it's not allowed). In our code
for flattening token trees we check if a pool is a subPool by if
mainIndex is defined or not, and so if this is left undefined it crashes
as it thinks a subpool is a high level pool.
The reason will be displayed to describe this comment to others. Learn more.
From some quick testing, I see the rate provider issue that Franz pointed out. Also, the portfolio page doesn't load the unstaked pools list. Actually it did but for some reason it took a long time initially.
@timjrobinson There are also issues with withdrawals. e.g. this pool on polygon 0xcd78a20c597e367a4e478a2411ceb790604d7c8f000000000000000000000c22 is trying to get me to do a recovery exit but it's not in recover mode. I can't exit in a single token.
@garethfulleravalanche does not show all pools on the beta app, I think the pool filter is wrong you pass to the api ["WEIGHTED", "STABLE", "META_STABLE", "STABLE", "STABLE", "GYRO3", "GYRO3", "GYROE"] you are missing some.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timjrobinson
force-pushed
the
feat/pools-from-beets-api
branch
from
Description
Switches all pool querying from the Old API / Subgraph to the new API. This makes the app dependent on the API as all fallbacks are removed.
Still todo:
Type of change
How should this be tested?
Checklist:
masterif hotfix,developif not