-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix: update dependencies to make apps work with turbopack #335
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -58,7 +58,7 @@ function EnsOrAddress({ userAddress, chain }: { userAddress: `0x${string}`; chai | |||
backgroundColor="background.level4" | |||
borderRadius="100%" | |||
height="24px" | |||
src={ensAvatar || fallbackSVG.toDataUriSync()} | |||
src={ensAvatar || fallbackSVG.toDataUri()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't do this because toDataUri
returns a promise. That's why Sync was required. Code will have to be refactored if for some reason we've lost toDataUriSync
.
The remaining real blocker is:
That said, in the medium term I would try to migrate to chakra 3 (only if its compat with nextjs 14/15 is production ready). |
Dependency updates and minimum fixes to make
turbopack
work.Just run
pnpm run dev
and enjoy the new DX 🚀TODO
Note that
turbopack
is not ready for builds so we need to keep the currentwebpack
config for builds.