Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: update dependencies to make apps work with turbopack #335

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

agualis
Copy link
Collaborator

@agualis agualis commented Dec 17, 2024

Dependency updates and minimum fixes to make turbopack work.

Just run pnpm run dev and enjoy the new DX 🚀

TODO

  • There is a hydration error.
  • Fix deprecation error in style foundations.
  • Sentry/nextjs lib is compatible but we should test it carefully and fix warnings.
  • Test all routes and scenarios.
  • Others?

Note that turbopack is not ready for builds so we need to keep the current webpack config for builds.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mono-beets-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:31am
mono-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:31am
mono-test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:31am

Copy link
Contributor

@garethfuller garethfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They hydration error is an issue in Chakra itself. This PR is blocked unless we can upgrade chakra to fix it.
Screenshot 2024-12-20 at 09 55 12

@@ -58,7 +58,7 @@ function EnsOrAddress({ userAddress, chain }: { userAddress: `0x${string}`; chai
backgroundColor="background.level4"
borderRadius="100%"
height="24px"
src={ensAvatar || fallbackSVG.toDataUriSync()}
src={ensAvatar || fallbackSVG.toDataUri()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't do this because toDataUri returns a promise. That's why Sync was required. Code will have to be refactored if for some reason we've lost toDataUriSync.

@garethfuller garethfuller marked this pull request as draft December 20, 2024 09:55
@agualis
Copy link
Collaborator Author

agualis commented Dec 20, 2024

They hydration error is an issue in Chakra itself. This PR is blocked unless we can upgrade chakra to fix it.
If that's the only issue I don't see it as a big blocker:
We can create a new script in package.json:
"dev:turbo": "next dev --turbo",
so that developers can chose this optional "experimental" mode (knowing that it has some hydration issues).

The remaining real blocker is:

Can'tdo this because toDataUri returns a promise. That's why Sync was required. Code will have to be refactored if for some reason we've lost toDataUriSync. It comes fromdicebear` update (required to make it compatible with turbopack) and we should be able to fix it to make it work as it used to.

That said, in the medium term I would try to migrate to chakra 3 (only if its compat with nextjs 14/15 is production ready).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants