Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: voting list #148
base: main
Are you sure you want to change the base?
feat: voting list #148
Changes from 6 commits
651e5a1
6711282
42b2658
1194364
b0577c4
d6fb3b1
02b10a7
f693867
21916eb
0970171
4929402
1dc1622
83649f0
b80e7d6
2b4774b
71a7b81
6829781
0212124
1da60f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be fetching data in this component and passing it into providers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayTokens
are deprecated in the API.Depending on what we need here, we can probably reuse some helpers from
pool.helpers
or we can implement the same logic that the api implements fordisplayTokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used getPoolDisplayTokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you replaced
pool={pool}
prop to spread its used fields so that you can reusePoolListTokenPills
component in the voting list.Instead of spreading the fields: chain, displayTokens, type... into the props I would create a new TS subtype that both the PoolListTableRow and the VotingListRow can satisfy.
For example:
that way its's easier to understand the purpose of that group of pool fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayTokens
is deprecated.