-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legacy rps #63
Add legacy rps #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factory needs updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mkflow27 for these changes. I like the schema validation you put in place!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with the revised review md files and formatting. Maxis will take responsbility of adding Chainlink rate providers as they are created as well as any others if they are not already included in this list.
This pr adds the following additions:
registry.json
Before this gets merged we should aim to add all the remaining assets to the RateProviders. Outstanding
After this pr has been merged
will be closed.