Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tokenized vaults to erc4626 registry #199

Merged
merged 10 commits into from
Dec 11, 2024

Conversation

Xeonus
Copy link
Contributor

@Xeonus Xeonus commented Dec 10, 2024

  • add gnosis and mainnet tokenized vaults as per code review
  • checked vault and asset as per PROD boosted pools in test UI
  • please cross-check correct setup. Goal is for tokenized vault warnings to go away

IMPORTANT: main registry with ERC4626 rate providers still needs to be populated to register boosted pool rate providers as well!

Example: Boosetd pool with waGNO and wstETH tokenized vaults
image

- add gnosis tokenized vaults as per code review
- checked vault and asset as per PROD boosted pools in [test UI](https://test.balancer.fi/pools?networks=MAINNET,GNOSIS&protocolVersion=3)
- please cross-check correct setup. Goal is for tokenized vault warnings to go away

IMPORTANT: main registry with ERC4626 rate providers still needs to be populated to register boosted pool rate providers as well!
@Xeonus Xeonus requested review from mkflow27 and danielmkm December 10, 2024 11:18
@Xeonus Xeonus changed the title feat: add tokenized gnosis vaults to erc4626 registry feat: add tokenized vaults to erc4626 registry Dec 10, 2024
@Xeonus
Copy link
Contributor Author

Xeonus commented Dec 10, 2024

Note: need to wait on final review and also merge on rate providers like #200

Copy link
Collaborator

@mkflow27 mkflow27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the review information. Waiting for Daniel to approve

@mkflow27 mkflow27 self-requested a review December 11, 2024 06:55
Copy link
Contributor

@danielmkm danielmkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work getting these done

@danielmkm danielmkm merged commit 1ab6672 into main Dec 11, 2024
1 check passed
@danielmkm danielmkm deleted the register-aave-boosted-erc4626-gnosis branch December 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants