Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize bytecode #701

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Optimize bytecode #701

merged 2 commits into from
Jul 1, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jun 28, 2024

Description

Make Vault and Router deployable.
We're going down with the Vault runs; if we can crawl back a few bytes tweaking the code we'll put the number back up if it results in gas savings.

For the router, adjusting the modifiers makes a big difference.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

N/A

- Fewer runs for main vault
- Optimize Router modifier
Copy link
Contributor

@elshan-eth elshan-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Optimize bytecode

Generated at commit: 46ab3533c28f7e69d2868f0e74454f5afb77b84e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
11
37
52
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@jubeira jubeira merged commit 78ffc4d into main Jul 1, 2024
12 checks passed
@jubeira jubeira deleted the optimize-bytecode branch July 1, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants