Remove unused HooksConfigLib arguments

[EndymionJkb]

Description

Little one to address a consequence of merging Hooks and Pool configs and remove distracting warnings. Saves a little gas, too.

Type of change

• Bug fix
• New feature
• Breaking change
• Dependency changes
• Code refactor / cleanup
• Documentation or wording changes
• Other

Checklist:

• The diff is legible and has no extraneous changes
• Complex code has been commented, including external interfaces
• Tests have 100% code coverage
• The base branch is either main, or there's a description of how to merge

Issue Resolution

[jubeira]

Why not just remove the argument and make a regular library call?

I'd just do HooksConfigLib.callComputeDynamicSwapFeeHook(swapParams, staticSwapFeePercentage, ...);

[EndymionJkb]

Why not just remove the argument and make a regular library call?

I'd just do HooksConfigLib.callComputeDynamicSwapFeeHook(swapParams, staticSwapFeePercentage, ...);

I had it like that originally, but didn't want to break the pattern of the others (since some do use the argument). Can see what it looks like that way.

[openzeppelin-code]

Remove unused HooksConfigLib arguments

Generated at commit: a4c9a8149f79fcda17c53c850f0abdd53fe3c0f5

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 2 0 11 37 52
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[jubeira]

I think this looks better, thanks @EndymionJkb.

I don't think 'breaking the pattern' is an issue here; this looks preferable compared to having unused function arguments for the sake of using the syntax sugar for libraries.