Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Price Impact Helper #323
Price Impact Helper #323
Changes from 22 commits
a238315
5c06a0a
447366e
b51856b
21dbcbf
bbd553c
daa6954
7f7a52c
fbfc101
682257d
2802842
5845a1e
558820b
61c20b6
af7e093
24f81e8
4e796a0
ab5c279
55b596f
8ce8373
cd8aaf7
e1d0a70
28ba108
c31fc64
3354423
7d847ac
36e15f1
b98b81f
f991bea
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can make a library out of this? There's no state to save or to access, so a library would seem better suited. Agree about making it a standalone module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is to reuse the hook right? Then I guess it's fine as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I don't get the back and forth here. Why is this a signed value if we always change the result to be positive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took me a while to see, but we check if delta is positive or negative, and then we return
result
or-result
. The returned value can be negative.