Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant CHANGELOGs #1176

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove redundant CHANGELOGs #1176

wants to merge 4 commits into from

Conversation

EndymionJkb
Copy link
Collaborator

Description

Are we using these? Here's one way we could. (Otherwise, should just delete them.)

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • [N/A] Complex code has been commented, including external interfaces
  • [N/A] Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say let's delete.

This sounds like an old artifact from the times where the monorepo also had deployments in it. Now it's completely separated, so I think this doesn't belong here.

@EndymionJkb EndymionJkb changed the title Update CHANGELOGs Remove redundant CHANGELOGs Dec 13, 2024
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants