-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medusa swap tests #1167
base: main
Are you sure you want to change the base?
Medusa swap tests #1167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I just commented on the property and optimization, but overall looks good!
@@ -8,7 +8,7 @@ | |||
"callSequenceLength": 10, | |||
"corpusDirectory": "medusa-corpus", | |||
"coverageEnabled": true, | |||
"targetContracts": ["AddAndRemoveLiquidityStableMedusaTest"], | |||
"targetContracts": ["AddAndRemoveLiquidityStableMedusaTest", "SwapMedusaTest"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Older versions of Medusa conflicted here (I was using 0.1.16 and it did not work), but upgrading to 0.1.18 made it work. Much better to have actions in different files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean we need to have two medusa.json
settings for each medusa test file?
Description
Add medusa swap tests to check that the invariant never decreases.
Type of change
Checklist:
main
, or there's a description of how to mergeIssue Resolution