Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: deploy vault factory with hardcoded salt #1138

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gosuto-inzasheru
Copy link

Description

adds tests that illustrate using a hardcoded salt to deploy the vault factory

Type of change

  • Other: more tests

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

@gosuto-inzasheru
Copy link
Author

➜ bytes internal constant _PROXY_BYTECODE = hex"67_36_3d_3d_37_36_3d_34_f0_3d_52_60_08_60_18_f3";
➜ bytes32 internal constant _PROXY_BYTECODE_HASH = keccak256(_PROXY_BYTECODE);
➜ _PROXY_BYTECODE_HASH
Type: bytes32
└ Data: 0x21c35dbe1b344a2488cf3321d6ce542f8e9f305544ff09e4993a62319a497c1f

Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

pkg/vault/test/foundry/VaultFactory.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/VaultFactory.t.sol Outdated Show resolved Hide resolved
pkg/vault/test/foundry/VaultFactory.t.sol Outdated Show resolved Hide resolved
@gosuto-inzasheru
Copy link
Author

@joaobrunoah i had to refactor due to #1154

please review again, can be merged directly after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants