Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Quote Tokens support for FXPools: FXPoolDeployerTracker #575

Merged

Conversation

andreiashu
Copy link
Contributor

@andreiashu andreiashu commented Mar 20, 2024

Description

End of last year we added support for FXPoolDeployer ( #527 ) which basically acts as a factory contract for FXPools: allows permissionless deployments of FXPool contracts. It has a 1:1 relationship with the quote token (eg. USDC) - ie. one FXPoolDeployer contract per quote token.

This PR adds the ability for our UI to track multiple FXPoolDeployer contracts through the subgraph, as we gradually add support for more quote tokens.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

How should this be tested?

We've deployed the changes over to our balancer subgraph polygon clone (trimmed down version, starting from block 49368321 ): https://thegraph.com/hosted-service/subgraph/xave-finance/balancer-v2-polygon

Simply run the "Query FXPools" from the query dropdown and it should return:

  • SBC / USDC.e: created with the previous/existing FXPoolDeployer contract that has USDC.e as quote token (tx)
  • XSGD / USDC : created with a new FXPoolDeployer contract that has USDC native as quote token (tx)

Checklist:

  • I have performed a self-review of my own code
  • I have requested at least 1 review (If the PR is significant enough, use best judgement here)
  • I have commented my code where relevant, particularly in hard-to-understand areas

dev -> master

  • I have checked that all beta deployments have synced
  • I have checked that the earliest block in the polygon pruned deployment is block, date/time
    • The earliest block is more than 24 hours old
  • I have checked that core metrics are the same in the beta and production deployments

Merges to dev

  • I have checked that the graft base is not a pruned deployment

@andreiashu andreiashu marked this pull request as ready for review March 20, 2024 07:59
@andreiashu andreiashu requested a review from mendesfabio as a code owner March 20, 2024 07:59
@mendesfabio mendesfabio changed the base branch from dev to staging-dev March 20, 2024 18:39
Copy link
Member

@mendesfabio mendesfabio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. I'm merging to staging-dev so we can update grafting params before merging to dev and starting the sync. Thank you!

@mendesfabio mendesfabio merged commit c4a7f0a into balancer:staging-dev Mar 20, 2024
2 of 4 checks passed
This was referenced Mar 20, 2024
@mendesfabio mendesfabio mentioned this pull request Apr 3, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants