Replacing CoingeckoTokenPriceService by ApiTokenPriceService to fetch… #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… token prices from the API instead of from coingecko;
Making 'api' the default token price service; Applying the coingecko config to the coingeckoTokenPriceService; bugfixing the token-prices/coingecko module to work correctly with the coingeckoConfig;
brunoguerios
approved these changes
Jan 26, 2024
balancer-js/src/modules/sor/token-price/coingeckoTokenPriceService.ts
Outdated
Show resolved
Hide resolved
added 6 commits
January 27, 2024 18:48
Improving maintainability for coingecko constants;
brunoguerios
deleted the
563-adapt-the-balancer-sdk-sor-to-not-use-coingecko-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… token prices from the API instead of from coingecko;