Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Preparation: ERC4626RateProviderFactory #95

Closed

Conversation

0xSpraggins
Copy link
Contributor

@0xSpraggins 0xSpraggins commented Nov 2, 2023

Deployment preparation: ERC4626RateProviderFactory

The build-info for this deployment was finalized at this commit in the metastable-rate-providers repo.

Deployment preparation tasks checklist:

  • Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test

Deprecating old tasks checklist:

  • Old task was moved to deprecated/ directory
  • Deployments README is updated: old task is moved to the 'deprecated' section, and links are updated with the deprecated/ prefix
  • Old task imports in index.ts, input.ts and fork tests are updated
  • Old task README is updated with a warning sign, a link to the replacement task and a short description

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

@0xSpraggins 0xSpraggins requested a review from jubeira November 2, 2023 19:37
@EndymionJkb
Copy link
Collaborator

I confirm the build-info matches. (Edited the commit link to point to the Balancer repo vs. the fork.)

@EndymionJkb
Copy link
Collaborator

There's a dead link:

ERROR: 1 dead links found!
[✖] ./tasks/20230915-erc4626-rate-provider-factory → Status: 400

FILE: ./CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants