Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment preparation: V3 Routers #127

Merged
merged 24 commits into from
Dec 5, 2024
Merged

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Dec 5, 2024

Deployment preparation: V3 Routers

Build-info: balancer/balancer-v3-monorepo@74d7068

All tasks have the same artifact, but I believe it's better to create separate tasks in case we ever deprecate any of them individually.

Deployment preparation tasks checklist:

  • Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test

Deprecating old tasks checklist: N/A

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@EndymionJkb
Copy link
Collaborator

Starting to look. I confirm the monorepo commit is correct, and the build-info files match as well.

The build-info in composite-liquidity-router is called Router; should be CompositeLiquidityRouter to match the others.

Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass done. Maybe we can port some fork tests over from v2 here? (Or adapt the v3 tests?)

v3/tasks/00000000-permit2/readme.md Show resolved Hide resolved
v3/tasks/20241205-v3-batch-router/readme.md Outdated Show resolved Hide resolved
v3/tasks/20241205-v3-batch-router/readme.md Outdated Show resolved Hide resolved
v3/tasks/20241205-v3-buffer-router/readme.md Outdated Show resolved Hide resolved
v3/tasks/20241205-v3-buffer-router/readme.md Outdated Show resolved Hide resolved
v3/tasks/20241205-v3-composite-liquidity-router/readme.md Outdated Show resolved Hide resolved
v3/tasks/20241205-v3-router/readme.md Outdated Show resolved Hide resolved
v3/tasks/20241205-v3-router/readme.md Outdated Show resolved Hide resolved
joaobrunoah
joaobrunoah previously approved these changes Dec 5, 2024
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can attest that the build-info of all routers matches the commit 74d7068fb21565741427cdabfa4f1b539a4bddaa of the V3 monorepo.

joaobrunoah
joaobrunoah previously approved these changes Dec 5, 2024
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for a readme comment, looks like everything is "aligned" (i.e., similarly named things aren't mixed up).

v3/tasks/20241205-v3-batch-router/readme.md Outdated Show resolved Hide resolved
joaobrunoah
joaobrunoah previously approved these changes Dec 5, 2024
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I already confirmed that build-info matches the correct commit of the monorepo.

joaobrunoah
joaobrunoah previously approved these changes Dec 5, 2024
v3/tasks/20241205-v3-buffer-router/test/task.fork.ts Outdated Show resolved Hide resolved
@jubeira jubeira merged commit e94346b into master Dec 5, 2024
30 checks passed
@jubeira jubeira deleted the deployment-preparation/routers branch December 5, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants