-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment preparation: V3 Routers
#127
Conversation
Starting to look. I confirm the monorepo commit is correct, and the build-info files match as well. The build-info in composite-liquidity-router is called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass done. Maybe we can port some fork tests over from v2 here? (Or adapt the v3 tests?)
v3/tasks/20241205-v3-composite-liquidity-router/test/task.fork.ts
Outdated
Show resolved
Hide resolved
…into deployment-preparation/routers
Co-authored-by: EndymionJkb <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can attest that the build-info of all routers matches the commit 74d7068fb21565741427cdabfa4f1b539a4bddaa of the V3 monorepo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for a readme comment, looks like everything is "aligned" (i.e., similarly named things aren't mixed up).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I already confirmed that build-info matches the correct commit of the monorepo.
Deployment preparation:
V3 Routers
Build-info: balancer/balancer-v3-monorepo@74d7068
All tasks have the same artifact, but I believe it's better to create separate tasks in case we ever deprecate any of them individually.
Deployment preparation tasks checklist:
README
is updated with the new task name and linkREADME
has a description and links to the artifactsbuild-info
is updated with artifacts compiled at the specified commitbuild-info
Deprecating old tasks checklist: N/A
Code checklist:
master
, or there's a description of how to mergeIssue Resolution