Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment preparation: V3 Stable Pool Factory #126

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Dec 5, 2024

Deployment preparation: V3 Stable Pool Factory

Build-info: balancer/balancer-v3-monorepo@25d73b3

Deployment preparation tasks checklist:

  • Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test

Deprecating old tasks checklist: N/A

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A
On top of #125; merge first and then rebase.

joaobrunoah
joaobrunoah previously approved these changes Dec 5, 2024
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Artifacts are matching the build-info of the monorepo at commit 25d73b3d091f5dde943ad6b7d90db9569222510d

v3/tasks/20241205-v3-stable-pool/readme.md Outdated Show resolved Hide resolved
@joaobrunoah
Copy link
Contributor

Very minor thing: I believe the title of the PR should be "Deployment preparation: V3 Stable Pool Factory", to match the pattern of the weighted pool PR

EndymionJkb
EndymionJkb previously approved these changes Dec 5, 2024
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the code commit is correct, and the build-info matches. Just one readme nit.

v3/tasks/20241205-v3-stable-pool/readme.md Outdated Show resolved Hide resolved
Base automatically changed from deployment-preparation/weighted-pool to master December 5, 2024 13:31
@jubeira jubeira dismissed stale reviews from EndymionJkb and joaobrunoah December 5, 2024 13:31

The base branch was changed.

@joaobrunoah joaobrunoah changed the title Deployment preparation: V3 Stable Pool Deployment preparation: V3 Stable Pool Factory Dec 5, 2024
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess I'll pile on! Still looks good.

@jubeira jubeira merged commit b3c66fe into master Dec 5, 2024
30 checks passed
@jubeira jubeira deleted the deployment-preparation/stable-pool branch December 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants