-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment preparation: V3 Stable Pool Factory
#126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Artifacts are matching the build-info of the monorepo at commit 25d73b3d091f5dde943ad6b7d90db9569222510d
Very minor thing: I believe the title of the PR should be "Deployment preparation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that the code commit is correct, and the build-info matches. Just one readme nit.
The base branch was changed.
V3 Stable Pool
V3 Stable Pool Factory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess I'll pile on! Still looks good.
Deployment preparation:
V3 Stable Pool Factory
Build-info: balancer/balancer-v3-monorepo@25d73b3
Deployment preparation tasks checklist:
README
is updated with the new task name and linkREADME
has a description and links to the artifactsbuild-info
is updated with artifacts compiled at the specified commitbuild-info
Deprecating old tasks checklist: N/A
Code checklist:
master
, or there's a description of how to mergeIssue Resolution
N/A
On top of #125; merge first and then rebase.