Deployment preparation: Fraxtal root gauge factory #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
reviewed
May 29, 2024
There was a problem hiding this comment.
See comment on naming. Also, we usually include manual bridge transactions for root gauges, to ensure the events are the same, etc. (e.g., #80)
|
@EndymionJkb added deposit tx to description (it's also in the inputs script). |
EndymionJkb
previously approved these changes
May 29, 2024
9 tasks
|
Updated build info and fork test now with gauge that has network tag. PTAL @EndymionJkb |
EndymionJkb
previously approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment preparation:
FraxtalRootGaugeFactoryBuild-info: balancer/balancer-v2-monorepo@281e98f.
The code is very similar to the Optimism Root Gauge; it just adds a network tag to identify the target L2.
The fork test is a mix between 'modern' gauge tests (Avax, Base) which use LZ-based gauges with the Optimism Root Gauge Factory test. The setup is the latest (i.e. it creates a synthetic veBAL whale) and all the cooldowns and periods are fixed, and it checks the Optimism bridge events (which are the same in OP and Fraxtal).
About the inputs: L1 token bridge and Fraxtal BAL addresses naturally differ between OP and Fraxtal. Besides that, the initial gas limit also differs: the one in this task was taken from a test TX.
Deposit TX sample: https://etherscan.io/tx/0xbbff35c8add8d11f2fac562731ec9dab58582c3a14b64580d01b8c757fc976bd
Recipient TX: https://fraxscan.com/tx/0x6b27d68f24275892a22c0a53d2de40cd4610c465b7c1233dc917580c0a855fc9
Deployment preparation tasks checklist:
READMEis updated with the new task name and linkREADMEhas a description and links to the artifactsbuild-infois updated with artifacts compiled at the specified commitbuild-infoDeprecating old tasks checklist: N/A
Code checklist:
master, or there's a description of how to mergeIssue Resolution
N/A