Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network deployment: Mode #116

Merged
merged 5 commits into from
May 22, 2024
Merged

Network deployment: Mode #116

merged 5 commits into from
May 22, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented May 22, 2024

Description

Deployment to Mode network. Similar to #114, but without veBAL support. Child chain gauges are deployed, but we don't expect to read veBAL balances.

Most of the contracts should be verified in modescan; only managed pool factory threw an error.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

EndymionJkb
EndymionJkb reviewed May 22, 2024
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the batch-relayer-v6; copy/pasted fraxtal reference

CHANGELOG.md Outdated Show resolved Hide resolved
tasks/20230411-managed-pool-v2/output/mode.json
"ManagedPoolAmmLib": "0x6817149cb753BF529565B4D023d7507eD2ff4Bc0",
"ExternalWeightedMath": "0x6B5dA774890Db7B7b96C6f44e6a4b0F657399E2e",
"RecoveryModeHelper": "0x7Ba29fE8E83dd6097A7298075C4AFfdBda3121cC",
"ManagedPoolFactory": "0x043A2daD730d585C44FB79D2614F295D2d625412",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the Pool verified, but not the Factory

tasks/20231031-batch-relayer-v6/input.ts Outdated Show resolved Hide resolved
@jubeira jubeira requested a review from EndymionJkb May 22, 2024 19:34
@jubeira
Copy link
Contributor Author

jubeira commented May 22, 2024

Good catch; thanks @EndymionJkb !

EndymionJkb
EndymionJkb approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All I noticed was the relayer thing. Looks good now.

Still didn't verify the Managed Pool factory, but it did everything else, and they're not used anyway

@jubeira jubeira merged commit 6d2aaf5 into master May 22, 2024
42 checks passed
@jubeira jubeira deleted the mode-deployment branch May 22, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubeira @EndymionJkb