Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Deprecate linear pools and child chain gauges V1 #115

Merged
merged 3 commits into from
May 22, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented May 21, 2024

Description

Linear pools should have been deprecated long ago; there is currently no plan to use them in V2 anymore.

We haven't been using old child chain gauges either: handling rewards with them is cumbersome when compared to the new child chain gauges V2, which are in use.

Skips deprecated tests, which will improve CI as well.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira
Copy link
Contributor Author

jubeira commented May 21, 2024

markdown links nailed on the first attempt 😎

@jubeira jubeira changed the title Cleanup Deprecate linear pools and child chain gauges V1 Cleanup: Deprecate linear pools and child chain gauges V1 May 21, 2024
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the new --bail option is good for this repo, too. Probably should have done this as soon as we decided not to revive them. Will definitely save some CI cycles

@jubeira jubeira merged commit e3d88d0 into master May 22, 2024
39 checks passed
@jubeira jubeira deleted the deprecate-linear-pools branch May 22, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants